TeamNovaSoft / discord-bot

Un bot de discord para automatizar algunas cosas en nuestros servidores
MIT License
2 stars 0 forks source link

Check if logic on index.js for deploy commands and events can be moved to deploy-commands.js #21

Closed heliomar-pena closed 1 day ago

heliomar-pena commented 1 week ago

Explanation

There is a file deploy-commands.js that is imported on index.js, and seems like it does the same that index on lines 15-30.

It seems like the bot is doing the job twice, loading commands twice. This task is to validate that, if that is the case, move the code that deploy commands on index.js to deploy-commands.js so we have index.js a bit more clean.

Also, create a new file deploy-events and move the logic for deploy the events to this file instead of have it on index.js

Screenshots

image

Checklist

This issue can be closed when the following tasks are complete:

heliomar-pena commented 1 week ago

I think the code on deploy-commands and the code on index do the same on that part, and we could move it completly to deploy-commands file. @YoelFerreyra do you know if it is actually like I say?

joset98 commented 3 days ago

I think the code on deploy-commands and the code on index do the same on that part, and we could move it completly to deploy-commands file. @YoelFerreyra do you know if it is actually like I say?

On theory it looks very similar, although both codes are necessary. I will try to unify both