search

TeamPiped / Piped-Kubernetes

GNU Affero General Public License v3.0
7 stars 5 forks source link

ytproxy bug and resources #20

Closed aleksasiriski closed 1 year ago

aleksasiriski commented 1 year ago

fixed missing .ytproxy in pod template and fixed resources

fixes #4

aleksasiriski commented 1 year ago

None of the scripts don't seem to do anything, and I don't get what is wrong with my PR and why do I need to regenerate your docs?

samip5 commented 1 year ago

why do I need to regenerate your docs?

That's due to the page on Artifacthub depends on the README, and otherwise it doesn't reflect changes at all nor version change.

$ .github/scripts/gen-helm-docs.sh apps piped: That worked fine, wdym it doesn't do anything?

aleksasiriski commented 1 year ago

$ .github/scripts/gen-helm-docs.sh apps piped: That worked fine, wdym it doesn't do anything?

bash .github/scripts/gen-helm-docs.sh

-] Copying templates to /somewhere/Piped-Kubernetes/charts/apps/piped
cp: not replacing '/somewhere/Piped-Kubernetes/charts/apps/piped/README_CONFIG.md.gotmpl'
INFO[2023-05-03T22:28:54+02:00] Found Chart directories [apps/piped]         
INFO[2023-05-03T22:28:54+02:00] Generating README Documentation for chart /somewhere/Piped-Kubernetes/charts/apps/piped 
WARN[2023-05-03T22:28:54+02:00] Error generating gotemplates for chart /somewhere/Piped-Kubernetes/charts/apps/piped: template: /somewhere/Piped-Kubernetes/charts/apps/piped:117: function "fromYaml" not defined
aleksasiriski commented 1 year ago 
bash .github/scripts/check-releasenotes.sh charts/apps/piped
usage: yq [-h] [--yaml-output] [--yaml-roundtrip]
          [--yaml-output-grammar-version {1.1,1.2}] [--width WIDTH]
          [--indentless-lists] [--in-place] [--version]
          [jq_filter] [files ...]
yq: error: argument files: can't open '.annotations."artifacthub.io/changes"': [Errno 2] No such file or directory: '.annotations."artifacthub.io/changes"'
aleksasiriski commented 1 year ago 
python .github/scripts/renovate-releasenotes.py apps/piped/
Trying to determine default branch...
Comparing against branch origin/HEAD
Updating changelog annotation for chart charts/apps/piped

this doesn't produce any changes that i can commit

samip5 commented 1 year ago 
bash .github/scripts/check-releasenotes.sh charts/apps/piped
usage: yq [-h] [--yaml-output] [--yaml-roundtrip]
          [--yaml-output-grammar-version {1.1,1.2}] [--width WIDTH]
          [--indentless-lists] [--in-place] [--version]
          [jq_filter] [files ...]
yq: error: argument files: can't open '.annotations."artifacthub.io/changes"': [Errno 2] No such file or directory: '.annotations."artifacthub.io/changes"'

It's not the same thing to invoke it with bash and w/o.

.github/scripts/check-releasenotes.sh charts/apps/piped vs bash .github/scripts/check-releasenotes.sh charts/apps/piped is not the same thing and the first one does indeed work while the latter doesn't for me either.

aleksasiriski commented 1 year ago

I believe it shoud be the same thing, I appended bash because I use fish. Running just .github/scripts/check-releasenotes.sh charts/apps/piped inside fish and inside bash produces the same error for me.

samip5 commented 1 year ago 
python .github/scripts/renovate-releasenotes.py apps/piped/
Trying to determine default branch...
Comparing against branch origin/HEAD
Updating changelog annotation for chart charts/apps/piped

this doesn't produce any changes that i can commit

That one is meant to work only for Renovate PRs as seen here: https://github.com/TeamPiped/Piped-Kubernetes/blob/main/.github/workflows/charts-changelog.yaml#L65