Creative compressor does not set the pressure

NoveIX commented 1 week ago

Describe the bug

I tried using the cretive compressor to set a pressure for the Pressur Chamber but the compressor pressure does not increase despite repeatedly clicking the button to increase the pressure

How to reproduce the bug

I tried to create a minecraft instance with only the mod. but still the compressor did not increase in temperature

Expected behavior

I expect the compressor to increase in pressure as written in the gui

Additional details

No response

Which Minecraft version are you using?

1.20.1

Which version of PneumaticCraft: Repressurized are you using?

6.0.17

Crash log

No response

desht commented 1 week ago

Can't reproduce this, working fine here. I use the Creative Compressor all the time for testing stuff, both in dev and outside dev, and never seen this occur.

NoveIX commented 5 days ago

I tried to do some tests. Each test I was creating a new minecraft instance and a new world. I tested the Pneumaticraft the latest version on several mod loaders even in the craftoria modpack but in all these tests the compressor remained at 0 bar nonstante we pressed the +1 button many times. I tried connecting it to the compression chamber thinking it was a graphical bug but it's not. the compressor doesn't work

1.20.1 - Forge 47.1.3 - Pneumaticcraft 6.0.18 1.20.1 - Forge 47.3.0 - Pneumaticcraft 6.0.17 - (this is the situation in my modpack) 1.20.1 - Forge 47.3.12 - Pneumaticcraft 6.0.18 1.20.1 - NeoForge 47.1.99 - Pneumaticcraft 6.0.18 1.20.1 - NeoForge 47.1.106 - Pneumaticcraft 6.0.18 1.21.1 - NeoForge 21.1.79 - Pneumaticcraft 8.2.4 1.21.1 - Craftoria 1.7.2 - Pneumaticcraft 8.2.3 1.21.1 - Craftoria 1.8.0 - Pneumaticcraft 8.2.3

Minecraft 1.20.1 From version 6.0.0 to version 6.0.5 Compressor works. From 6.0.6 to the latest (6.0.18) the compressor does not work
Minecraft 1.21.1 None of the versions the compressor works

desht commented 5 days ago

6.0.6 added this related feature:

Creative Compressor GUI can now do fast-adjust of block's pressure level by holding Shift while clicking (x5 adjust)

Hmm, what's your language set to? Both in Minecraft and in your operating system? This could be a formatting issue where numbers are encoded in one locale on the client and attempting to be decoded in a different one on the server (always en_us). Would explain why I've never seen the problem.

desht commented 5 days ago

Can you test out https://modmaven.dev/me/desht/pneumaticcraft/pneumaticcraft-repressurized/8.2.5+mc1.21.1-SNAPSHOT/pneumaticcraft-repressurized-8.2.5+mc1.21.1-20241118.102138-3.jar (for 1.21) and see if it works for you?

NoveIX commented 4 days ago

My operating system has EN_US as language I play Minecraft always with EN_US vanilla and modded.

However, my keyboard is Italian. I installed the key layout from Windows settings. I thought that was it, but even trying to install the EN_US layout the problem remained.

NoveIX commented 4 days ago

I tested the version you sent me on neoforge 21.1.80.

The compressor works I managed to craft with the pressure chamber and also blew it up from too many bars🤣.

If you can use it as information. I always have Operating system and minecraft in EN_US. i only installed the Italian layout.

desht commented 4 days ago

Interesting, I would expect it to work with an en_us locale. But in any case, glad this changes fixes the issue, it will be in the next PNC:R release, coming soon.

NoveIX commented 4 days ago

Thank you very much. i am glad to have helped solve a problem

desht commented 4 days ago

And thank you for the detailed detective work. Made it much easier to work out what happened.

TeamPneumatic / pnc-repressurized