[BUG] Custom scores do not work properly

[waiei]

Please give System Info

OS: Windows10 Pro

CPU: i5-7500 3.4GHz

GPU: GeForce GTX 1060 6GB

Storage: SSD

Please give your StepMania Info

StepMania Version: Project OutFox 5.3 Alpha 4.9.9HF2 Theme: Soundwaves(Default) + Use the custom score

Describe the problem

I think this problem has been discussed on Discord before, but it was not fixed in 4.9.9HF2, so I'm reporting it again.

When InternalScoring is not used, SetScore sometimes does not work correctly. Even if SetScore(0) is set to always be 0, sometimes the score is added as if InternalScoring=true.

So I checked the condition and found that it seems to occur only when the last judgment is Hold/Roll. For example, when the Hold and Tap are simultaneous at the end of the chart, the phenomenon does not occur when the Tap is Slow, but it does occur when the Tap is Fast.

• metrics.ini

[Global]
FallbackTheme=default

[Gameplay]
UseInternalScoring=false
UseInternalJudgment=false

• BGAnimations/ScreenGameplay overlay.lua

SCREENMAN:SystemMessage('override theme')
return Def.ActorFrame({
    LoadActor('/Appearance/Themes/default/BGAnimations/ScreenGameplay overlay'),
    Def.Actor({
        JudgmentMessageCommand = function(self, params)
            local stats = STATSMAN:GetCurStageStats():GetPlayerStageStats(params.Player)
            stats:SetScore(0)
        end,
    }),
})

Describe what should happen

The score should be the value set in SetScore.

[Scraticus]

Thanks for reporting! We'll look into this for the next major alpha.

Getting 4.9.9 right finally took a bit longer than we thought