Tech-N-Science / FunwithScience

MIT License
124 stars 218 forks source link

Issue #389 - About Us Page - Suvangi #669

Closed Urstrulysuvangi closed 2 years ago

Urstrulysuvangi commented 2 years ago

Create an About Page

Fixes: #389

Changes Made:

I made a separate section for the About Section as instructed by the project maintainers. I have used simple HTML and CSS to do this. I have taken reference from #414 in designing and building the section. I added a couple of pictures for enhancement purposes. All images used are copyright free. Tried my best to maintain the responsiveness of the webpage. The pictures are attached below.

P.S. Please note I had to force install the node-modules due to version error/incompatibility

Checklist:

Screenshots

githubfunwithScience1 (Desktop View)

githubfunwithScience2 (Tablet View)

githubfunwithScience3 (Mobile View)

github-actions[bot] commented 2 years ago

Our team will soon review your PR. Thanks @Urstrulysuvangi :)

Amit366 commented 2 years ago

@Urstrulysuvangi did u add it in a new page?

Urstrulysuvangi commented 2 years ago

@Urstrulysuvangi did u add it in a new page?

No I made the changes in the home.js (after the learn section, indicated by the comment : "About Us Section") and home.css files.

But as I mentioned before I did have to force install some modules due to version incompatibility so there are few changes seen in the package-lock.json, package.json and yarn.lock but I didn't intentionally change anything in them.

github-actions[bot] commented 2 years ago

Thank you @Urstrulysuvangi for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :).