Closed slifty closed 4 years ago
This all sounds good and I'll give more substantive feedback later, but some quick feedback:
Re: Next Steps:
Add to dynamic data, unless it's captured by "newsletter description": the opening and closing text (which I called "boilerplate" in the templates). It differs slightly between NC/National list. I think a large chunk of it is shared, but it differs in slight ways between newsletters.
Yeah, just adding on to @reefdog - if "newsletter description" refers to the top text, then we should also have "newsletter footer text" or something to capture the bottom text (unless "description" is meant to encompass both).
Also, for the "things that are not being engineered around yet" list, I would include "multiple social media sources."
Otherwise, this looks good to me and Mark!
Right now newsletters are implemented through code; each newsletter we want to create requires a new newsletter template, queue, and updated constants. This was OK before since we only had two newsletters, but we always knew there would be the potential for an arbitrary number of newsletters.
It is time to rethink this, and make the concept of unique newsletters data driven. We'll want newsletters to fit a common template with sections that are enabled or disabled depending on the content for a given day. We'll need to be able to have custom sources for claims as well (e.g. unique lists of twitter account, and eventually unique TV streams, known speakers, or keyword matches).
We don't have to boil the entire ocean yet, and can probably start with the following parameters:
Things that are NOT being engineered around yet:
Next Steps
I'm creating the issue for actually working on this and am starting along that path. In the mean time, some questions: