search

Techcable / pircbotx

Automatically exported from code.google.com/p/pircbotx
0 stars 0 forks source link

Ident server fails to respond correctly #173

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Start ident server
2. Send ident request for a valid user

What is the expected output? What do you see instead?
Instead of the correct ident response, the ident server replies with the 
original message.

What version of the product are you using? On what operating system?
2.1-SNAPSHOT

Please provide any additional information below.

Referring to the code (for version 2.1-SNAPSHOT), the ident server replies to 
the server with the line it sent, not the response. 
 http://code.google.com/p/pircbotx/source/browse/src/main/java/org/pircbotx/IdentServer.java#198
On line 199, the response to the server is created, and on line 200 is 
outputted to the log, however on 201, the ident server outputs the original 
message, which is not valid. This fails the ident.

This also occurs above it with the no-user message as well.

Original issue reported on code.google.com by Lordra...@gmail.com on 18 Apr 2014 at 2:42

GoogleCodeExporter commented 9 years ago 
I could of swore I tested that class, but that could of just been something I 
told myself when I was tired at 2am. 

Fixed (along with a few other massive bugs) in Revision 0c061dc44921. And yes, 
there's now multiple tests added in  Revision 79e0e30a9d0e

Original comment by Lord.Qua...@gmail.com on 21 Apr 2014 at 3:14