TechnikEmpire / DistillNET

DistillNET is a library for matching and filtering HTTP requests and HTML response content using the Adblock Plus Filter format.
Mozilla Public License 2.0
16 stars 4 forks source link

Performance sucks in >= 1.4.x #12

Closed TechnikEmpire closed 7 years ago

TechnikEmpire commented 7 years ago

Performance went down the tubes with the 1.4 .NET standard migration. Because we change sqlite libs, I thought this might have been the problem. However, it turns out that the use of hashsets for the domains option, a change made in 1.4, was the major issue.

This library will not assume responsibility for ensuring that your inputs don't list the same data multiple times, nor that your inputs are case correct. The cost is too high and we're solving problems that we shouldn't be.