search

TehNut-Mods / HWYLA

A fork of Waila maintaining it for new MC versions
https://bitbucket.org/ProfMobius/waila
Other
121 stars 72 forks source link

Unemployed villagers mislabeled #202

Open Boobies opened 5 years ago

Boobies commented 5 years ago

Villagers that are unemployed are labeled as as nitwits. When profession is set to none, then they are just unemployed.

Artoria2e5 commented 4 years ago

Still happens with Hwyla-fabric-1.15.2-1.9.20-71.jar. @TehNut I can't find the villager HUD code any more -- where the heck did that go in the Fabric port?

If it was still there, the fix should look like:

ITextComponent profession = new TextComponentTranslation("entity.minecraft.villager." + career.getName());

With new entries in the translation JSON:

{
  "entity.minecraft.villager.none": "Unemployed",
  "entity.minecraft.villager.nitwit": "Nitwit"
}
sonicer105 commented 3 years ago

I was able to solve this issue (and #290) by removing this line:

"entity.minecraft.villager.none": "Nitwit"

From the end of the file src/main/resources/assets/waila/lang/en_us.json

I don't understand why we are even overwriting the default Minecraft language here