TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
164 stars 26 forks source link

Game Soft-Locks when approaching a chunk containing Underground Bastions #277

Closed MikeMassotto closed 1 year ago

MikeMassotto commented 1 year ago

While following an Underground Bastion map, I found that upon getting close enough to the chunk containing the bastion the game would "soft-lock" (entities stopped moving, fall damage disabled, new chunks stopped loading, blocks would not drop items, etc.). It is likely a compatibility issue. I have included my CurseForge export of my modpack AND the world I am encountering this issue in. Please email me at mdmassotto@gmail.com if you manage to solve this. Thank you so much for the wonderful mod!

https://drive.google.com/file/d/1PLJ-mKIb30ClzfOFiyfuw0u8OhLBrWs8/view?usp=share_link

TelepathicGrunt commented 1 year ago

Looks like Structure Gel API is at fault here: https://controlc.com/a9c568a6

I got the game to hang and I performed a thread dump to see what code the game is stuck on. Structure Gel API is checking if a mob is in bounds of a structure but is using the entity's ServerLevel instead of the WorldGenRegion level. Which makes the generating chunk wait on itself and deadlocks

MikeMassotto commented 1 year ago

Thank you for the timely response! Is there a way I can fix this without removing the Structure Gel API?

On Wed, Apr 12, 2023 at 12:23 PM TelepathicGrunt @.***> wrote:

Looks like Structure Gel API is at fault here: https://controlc.com/a9c568a6

I got the game to hang and I performed a thread dump to see what code the game is stuck on. Structure Gel API is checking if a mob is in bounds of a structure but is using the entity's ServerLevel instead of the WorldGenRegion level. Which makes the generating chunk wait on itself and deadlocks

— Reply to this email directly, view it on GitHub https://github.com/TelepathicGrunt/RepurposedStructures/issues/277#issuecomment-1505568729, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXZZVEJR5KUDTYKS2LXS7HLXA3JG3ANCNFSM6AAAAAAW34FJXM . You are receiving this because you authored the thread.Message ID: @.***>

-- [image: NJIT logo] https://www.njit.edu/ Michael D Massotto

@.*** •

TelepathicGrunt commented 1 year ago

I made issue report to them: https://gitlab.com/modding-legacy/structure-gel-api/-/issues/36

No you cannot fix it without removing the mod as far as I know. Disabling Dungeons Plus might work. The issue looks like it could happen for any structure spawning skeletons during worldgen.

MikeMassotto commented 1 year ago

Alright, thanks a bunch btw!

On Wed, Apr 12, 2023 at 12:36 PM TelepathicGrunt @.***> wrote:

I made issue report to them: https://gitlab.com/modding-legacy/structure-gel-api/-/issues/36

No you cannot fix it without removing the mod as far as I know. Disabling Dungeons Plus might work. The issue looks like it could happen for any structure spawning skeletons during worldgen.

— Reply to this email directly, view it on GitHub https://github.com/TelepathicGrunt/RepurposedStructures/issues/277#issuecomment-1505586785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXZZVEMZ4LCNLR5GIRVIU3TXA3KZRANCNFSM6AAAAAAW34FJXM . You are receiving this because you authored the thread.Message ID: @.***>

-- [image: NJIT logo] https://www.njit.edu/ Michael D Massotto

@.*** •

TelepathicGrunt commented 1 year ago

Structure Gel API and Dungeons Plus just updated now to fix the issue! Update them and your would should be safe again to explore: https://gitlab.com/modding-legacy/structure-gel-api/-/issues/36#note_1352485824