search

TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
164 stars 26 forks source link

better strongholds compat not working #301

Closed Boba194230 closed 1 year ago

Boba194230 commented 1 year ago

_few things, first, can you please make a separate issue report instead of clogging up this one? This issue report is for documenting datapack to make, not for support.

Second, the datapack works for me so it’s likely something that you’re doing. There is an order to datapacks and you’ll want the datapack you put on to be after the mod’s own internal datapacks. So that the datapack overrides the mod’s files and not other way around_

Originally posted by @TelepathicGrunt in https://github.com/TelepathicGrunt/RepurposedStructures/issues/113#issuecomment-1725043834

Sorry I saw someone else asking for help in that thread so I thought I would too. How exactly would I go about changing the load order since I’m using global packs? Shouldn’t it automatically be after?

Boba194230 commented 1 year ago

Also I found the command to change load order but I’m not exactly sure how to change the mods internal stuff to load before as I’m pretty sure all the data packs get loading after my mods when I check the servers console

Boba194230 commented 1 year ago

I've done the command to change the load order and put it last and reloaded and generated a new one and it still didn't work. Odd

Boba194230 commented 1 year ago

Maybe modern fix causes incompatibilities?

Boba194230 commented 1 year ago

Just disabled and didn't change anything

Boba194230 commented 1 year ago

Disabled the stronghold remover datapack and still doesn't work :/

Boba194230 commented 1 year ago

I guess next I’ll try moving from my dedicated server to just my client and start testing mods 1 by 1 and see what causing it :/

TelepathicGrunt commented 1 year ago

I am using Global Packs mod and I put my datapack in the resourcepacks folder. image

Yung's Better Strongholds turns off the vanilla strongholds. It turns out that Stellarity and Taverns both modify the vanilla strongholds which imo, is the wrong way to do it. What they should had done is disable the vanilla stronghold and provide their own stronghold as their own structures. I made this small datapack that disables yung's strongholds, move stellarity and taverns into their own separate structures, and made eyes of ender be able to find those new strongholds. disable_yung_enable_taverns_and_stellarity.zip

Here's a test with Repurposed Structures, Better Strongholds, Stellarity, Taverns, Repurposed Structures - Better Strongholds Compat Datapack, and the new datapack i just posted above: image image image image image

Everything is working as expected in my testing. Only issue I see is taverns/stellarity strongholds takes so long to generate their layout that it will lag locate and eyes of ender a significant ton. Your server could deadlock as a result so locate with care with those mod's strongholds. Repurposed Structures's strongholds generates its layout super fast and shouldn't deadlock the server

Boba194230 commented 1 year ago

It appears that it only works on my client not the dedicated server.

TelepathicGrunt commented 1 year ago

Closing as this was resolved. Everything should be good