search

TelepathicGrunt / RepurposedStructures

Reusing and modifying vanilla structures for extra variety!
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures
GNU Lesser General Public License v3.0
164 stars 26 forks source link

Crash when generating map #313

Closed nightpool closed 11 months ago

nightpool commented 12 months ago

The server crashed while trying to generate a new map for a villager trade:

[05:24:29] [Server Watchdog/ERROR]: A single server tick took 60.00 seconds (should be max 0.05)
[05:24:29] [Server Watchdog/ERROR]: Considering it to be crashed, server will forcibly shutdown.
Crash report:
---- Minecraft Crash Report ----
// Daisy, daisy...

Time: 2023-11-26 05:24:30
Description: Watching Server

java.lang.Error: Watchdog
        at net.minecraft.class_2919.method_43052(class_2919.java:50)
        at net.minecraft.class_2919.method_12665(class_2919.java:78)
        at com.telepathicgrunt.repurposedstructures.world.structures.placements.AdvancedRandomSpread.method_40169(AdvancedRandomSpread.java:110)
        at net.mehvahdjukaar.supplementaries.common.worldgen.StructureLocator.addAllPossibleFeatureChunksAtDistance(StructureLocator.java:212)
        at net.mehvahdjukaar.supplementaries.common.worldgen.StructureLocator.findNearestMapFeatures(StructureLocator.java:148)
        at net.mehvahdjukaar.supplementaries.common.worldgen.StructureLocator.findNearestRandomMapFeature(StructureLocator.java:44)
        at net.mehvahdjukaar.supplementaries.common.entities.trades.AdventurerMapsHandler.createMapOrQuill(AdventurerMapsHandler.java:161)
        at net.mehvahdjukaar.supplementaries.common.entities.trades.AdventurerMapsHandler$RandomAdventureMapTrade.method_7246(AdventurerMapsHandler.java:126)
        at net.minecraft.class_3988.method_19170(class_3988.java:251)
        at net.minecraft.class_1646.method_7237(class_1646.java:898)
[truncated]

Full crash report here: https://gist.github.com/nightpool/d9c13afc7388eab99a7097ba91132122

The proximate cause seems to be a deadlock between calling ChunkRandom#setSeed in two different threads at the same time

TelepathicGrunt commented 12 months ago

It’s not a deadlock. That’s what the code path vanilla structure placement logic continuously runs through as it tries to locate a structure.

supplementaries is trying to locate an rs structure and is taking too long for whatever reason. Looks more like a supplementaries issue as if it was RS’s code running, RS generates its own map trades asynchronously to not lock up the server. supplementaries does not do it asynchronously and seems to be the own doing the locating here instead. RS is not at fault.

TelepathicGrunt commented 11 months ago

@nightpool Please update supplementaries to latest and try again. The issue should be resolved now on their end. I'll close automatically if I don't hear back in a week

nightpool commented 11 months ago

Thanks for the update! I'll try it out. Do you have a link to a commit/PR for reference?

On Wed, Nov 29, 2023, 9:00 PM TelepathicGrunt @.***> wrote:

@nightpool https://github.com/nightpool Please update supplementaries to latest and try again. The issue should be resolved now on their end. I'll close automatically if I don't hear back in a week

— Reply to this email directly, view it on GitHub https://github.com/TelepathicGrunt/RepurposedStructures/issues/313#issuecomment-1833030832, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZCV3T5CLJRSONFSPQK3LYG7ZDFAVCNFSM6AAAAAA72TN7H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTGAZTAOBTGI . You are receiving this because you were mentioned.Message ID: @.***>

TelepathicGrunt commented 11 months ago

I don’t have any links on hand. I assumed the map stuff changelog update was it. I did already let the dev know and he was working on fixing the issue as it seemed he might had missed a condition that should’ve avoided the issue. It could also be that it is loading village tagged structure but his system located all structures in that tag. And since rs has nether villages, it could be stuff looking for nether villages in overworld. Or it could also be taking too long to find all the overworld villages as some are very rare like badlands or mushroom or so.

nightpool commented 11 months ago

Makes sense! Thanks for the detailed explanation

On Thu, Nov 30, 2023 at 7:30 AM TelepathicGrunt @.***> wrote:

I don’t have any links on hand. I assumed the map stuff changelog update was it. I did already let the dev know and he was working on fixing the issue as it seemed he might had missed a condition that should’ve avoided the issue. It could also be that it is loading village tagged structure but his system located all structures in that tag. And since rs has nether villages, it could be stuff looking for nether villages in overworld. Or it could also be taking too long to find all the overworld villages as some are very rare like badlands or mushroom or so.

— Reply to this email directly, view it on GitHub https://github.com/TelepathicGrunt/RepurposedStructures/issues/313#issuecomment-1833683717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZCV7KG7V246SLZ3QWRJDYHB35VAVCNFSM6AAAAAA72TN7H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZTGY4DGNZRG4 . You are receiving this because you were mentioned.Message ID: @.***>

TelepathicGrunt commented 11 months ago

Looks like supplementary made a commit that will change their map logic to pick one structure from a structure tag to find instead of trying to find all entry. Should reduce their map load times https://github.com/MehVahdJukaar/Supplementaries/commit/2cfda0ab5c26aea75c647ce0895ff8c13e27d039

Closing as supplementary got a solution to resolve their map times

nightpool commented 11 months ago

not quite as good as doing it in a background thread but hopefully it won't trigger the watchdog anymore

On Fri, Dec 1, 2023 at 7:37 PM TelepathicGrunt @.***> wrote:

Looks like supplementary made a commit that will change their map logic to pick one structure from a structure tag to find instead of trying to find all entry. Should reduce their map load times @.*** https://github.com/MehVahdJukaar/Supplementaries/commit/2cfda0ab5c26aea75c647ce0895ff8c13e27d039

Closing as supplementary got a solution to resolve their map times

— Reply to this email directly, view it on GitHub https://github.com/TelepathicGrunt/RepurposedStructures/issues/313#issuecomment-1836984101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZCV5VZLRYXFLGODU7QOLYHKA4ZAVCNFSM6AAAAAA72TN7H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZWHE4DIMJQGE . You are receiving this because you were mentioned.Message ID: @.***>