search

TelepathyIM / telepathy-qt

Telepathy Qt bindings
https://telepathy.freedesktop.org
GNU Lesser General Public License v2.1
25 stars 14 forks source link

FindQt: Fix wrong version number matching #33

Closed litcoder closed 5 years ago

litcoder commented 5 years ago

As the CMake MATCH takes regex parameter, sub-string could unexpectedtly be matched. QT verseion 5.12.4, for instance, will be matched not just for QT5 but also for QT4 due to the sub-string '4' which is unexpected. This patch resolves the issue by constraining version number testing for Major version numbers only.

Signed-off-by: Brandon Hong brandon.hong@intel.com

Kaffeine commented 5 years ago

:man_facepalming: Thank you! I'll merge the commit in a few hours.