search

Telerik-Verified-Plugins / ImagePicker

Cordova Plugin For Multiple Image Selection
MIT License
182 stars 331 forks source link

Migrate to android x #201

Open TaaBooThree opened 4 years ago

TaaBooThree commented 4 years ago

Some of the packages use old android support packages.

Android wants everyone to migrate to androidx packages. Can we bump these imports?


// MultiImageChooserActivity.java

import android.support.v7.app.ActionBar;
import android.support.v7.app.AppCompatActivity;

// ImagePicker.java

import android.support.v4.app.ActivityCompat;
import android.support.v4.content.ContextCompat;
ugurcagridogan commented 4 years ago

Any progress on this ? We have almost 2 weeks left if I'm not wrong. Otherwise, we'll have to ditch this plugin.

TaaBooThree commented 4 years ago

Any progress on this ? We have almost 2 weeks left if I'm not wrong. Otherwise, we'll have to ditch this plugin.

@ugurcagridogan

If you can you can run jetifier to update your packages. I found this out way to late as well.

If you can run the npx jetifier command in your build pipeline somewhere you'll be safe in your builds.

good luck champ!

ugurcagridogan commented 4 years ago

Any progress on this ? We have almost 2 weeks left if I'm not wrong. Otherwise, we'll have to ditch this plugin.

@ugurcagridogan

If you can you can run jetifier to update your packages. I found this out way to late as well.

If you can run the npx jetifier command in your build pipeline somewhere you'll be safe in your builds.

good luck champ!

Somehow I managed to build it successfully after struggling with gradle and capacitor versions. Thank you.

clarklight commented 3 years ago

@ugurcagridogan Are you building it on Cordova? I am still struggling with it....maybe it would be easier to import the changes for the next version update for the plugin.