TelescopeSt / Telescope

Telescope is an engine for efficiently creating meaningful visualizations
MIT License
31 stars 9 forks source link

Adding new test method: testCopyAsSimpleStrategy #162

Open mabdi opened 4 years ago

mabdi commented 4 years ago

I submit this pull request to suggest a new test method TLNodeCreationStrategyTest>>#testCopyAsSimpleStrategy.

We noticed that #copyAsSimpleStrategy is never executed by any of the tests in TLCompositeNodeTest. Since this method contains technical debt it is best to guard against future evolutions which may break assumptions made by clients.

Note that these suggestions are adapted from a test amplification tool called SmallAmp (https://github.com/mabdi/small-amp). SmallAmp executes existing tests, sees which parts of the class under test are not covered and then suggests improvements on the test methods.

I hope you will accept this pull request. It would illustrate that SmallAmp makes relevant suggestions.

Mehrdad Abdi.