Tencao / MoreBees

a mod that adds more bees to minecraft forestry
11 stars 12 forks source link

Rocky Comb should produce Beeswax and Honey Drop when put in the Centrifuge #85

Open The-Fireplace opened 5 years ago

The-Fireplace commented 5 years ago

At the moment, it can't be put in the Centrifuge at all. Forestry 5.8.2.354 More Bees 1.12.2-2.0.1

NimonoSolenze commented 5 years ago

This unfortunately isn't so much a bug as a massive oversight- if you look at the code in src/main/java/com/tencao/morebees/recipes/RecipesCentrifuge.kt:

    if (Loader.isModLoaded("IC2")) {
        RecipeManagers.centrifugeManager.addRecipe(20, ItemStack(MBItems.CombRock), ImmutableMap.of(
                ModuleCore.getItems().beeswax.itemStack, 1.0f,
                ItemStack(Blocks.STONE, 1, 1), 0.5f,
                ItemStack(Blocks.STONE, 1, 3), 0.5f,
                ItemStack(Blocks.STONE, 1, 5), 0.5f,
                OreDictUtil.getOreStack("dustStone"), 0.9f))
    }
    if (Loader.isModLoaded("IC2-Classic-Spmod")){
        RecipeManagers.centrifugeManager.addRecipe(20, ItemStack(MBItems.CombRock), ImmutableMap.of(
                ModuleCore.getItems().beeswax.itemStack, 1.0f,
                ItemStack(Blocks.COBBLESTONE), 0.9f,
                ItemStack(Blocks.STONE, 1, 1), 0.5f,
                ItemStack(Blocks.STONE, 1, 3), 0.5f,
                ItemStack(Blocks.STONE, 1, 5), 0.5f))

}

This means that unless your pack has IndustrialCraft 2, you will never be able to centrifuge Rocky Combs- yet Rocky Combs can be obtained without IC2, because Rocky is a base bee in the mod!

Tencao commented 5 years ago

Thanks for pointing this out, I'll see about fixing this as soon as possible

Routhinator commented 4 years ago

Hi @Tencao - I have comitted PR #89 to address this bug. Please merge when you have time.

ghost commented 4 years ago

Bump, this still needs fixing!