search

Tencent / Shadow

零反射全动态Android插件框架
BSD 3-Clause "New" or "Revised" License
7.43k stars 1.3k forks source link

支持 id 'com.tencent.shadow.core' version 'x.x.x' apply false 的插件应用方式 #1319

Closed XuchengJie closed 5 months ago

XuchengJie commented 5 months ago

8.x gradle 应用插件 id 'com.tencent.shadow.core' version 'x.x.x' apply false会报错，发布到maven仓库时增加com.tencent.shadow.core.gradle.plugin即可。

tencent-adm commented 5 months ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

shifujun commented 5 months ago

抱歉，我操作失误了。刚帮你改了一下代码，push时误把master push上来了。结果github以为这个PR什么都没改，自动给关了。然后我就没权限再push修正了。

麻烦git fetch https://github.com/shifujun/Shadow 1319获取我修改的提交，然后重新提一下PR。

shifujun commented 5 months ago

主要修改3点：

  1. commit message有格式要求。也同时说明这种机制叫Plugin Marker。
  2. 保持apply plugin: 'com.tencent.shadow.plugin'和id 'com.tencent.shadow.plugin'使用相同的字符串。我看这也是gradle 插件通常的做法。
  3. 在AGP自动化测试中使用id 'com.tencent.shadow.plugin'
shifujun commented 5 months ago

我直接重提了。

XuchengJie commented 5 months ago

我直接重提了。

好的，太效率了