search

Tendrl / monitoring-integration

Component that enables integration with external monitoring services.
GNU Lesser General Public License v2.1
4 stars 13 forks source link

Removed Subvolume panel from Volume dashboard #571

Closed GowthamShanmugam closed 6 years ago

GowthamShanmugam commented 6 years ago

bugzilla: 1614263 tendrl-bug-id: Tendrl/monitoring-integration#570

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

GowthamShanmugam commented 6 years ago

removed_sub_vol

@cloudbehl i removed this from code directly not removed from grafana and copied json, please review this PR and check my changes are correct

GowthamShanmugam commented 6 years ago

I tested dashboard is looks fine

GowthamShanmugam commented 6 years ago

@mbukatov @julienlim

codecov[bot] commented 6 years ago

Codecov Report

Merging #571 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   45.08%   45.08%           
=======================================
  Files          40       40           
  Lines        2300     2300           
  Branches      345      345           
=======================================
  Hits         1037     1037           
  Misses       1210     1210           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c46ae97...87a689b. Read the comment docs.

GowthamShanmugam commented 6 years ago

remove_subvol

Modified alignment as per @shtripat comment

shtripat commented 6 years ago

Looks good to me now

cloudbehl commented 6 years ago

@GowthamShanmugam @shtripat I will recommend we should not reduce the alignment of any panel. We can increase it but reduction may lead to some regressions.

I will recommend we change the rebalance status back to the original width. If we want to change the width of geo-rep then we can reduce the width of the rebalance panel.

GowthamShanmugam commented 6 years ago

@cloudbehl i reverted back that new change