search

Terasology / Alchemy

Brewing potions and fun things!
1 stars 3 forks source link

Fix delay issue when brewing potions. #2

Closed xrtariq2594 closed 8 years ago

xrtariq2594 commented 8 years ago

There's a noticeable delay between adding ingredients to the Herbalism Station (both the portable and non-portable versions), and when the recipes list on the right is updated. I presume either the update interval for the HerbalismWindow UI is too small, or there aren't any callbacks when herbs are placed on/removed from the HerbalismStation input slots.

skaldarnar commented 8 years ago

How many recipes are searched to find fitting ones? Could there also be a bottleneck when looking through all recipes all over again? Probably this needs some clever caching or better data structures for searching/comparing.

On Thu, Oct 6, 2016, 21:58 XTariq notifications@github.com wrote:

There's a noticeable delay between adding ingredients to the Herbalism Station (both the portable and non-portable versions), and when the recipes list on the right is updated. I presume either the update interval for the HerbalismWindow UI is too small, or there aren't any callbacks when herbs are placed on/removed from the HerbalismStation input slots.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Terasology/Alchemy/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYbqv0_FvtQ_lNME-WS70qfFZGHfn3Dks5qxVLrgaJpZM4KQWjH .

xrtariq2594 commented 8 years ago

I believe this is related to the earlier issue in resolved in WorkstationCrafting.

Specifically, this one.

xrtariq2594 commented 8 years ago

Alright, I think I got this one fixed. The fix should be in the develop branch.

xrtariq2594 commented 8 years ago

This issue has been resolved with the merge of PR #4.