test: expect the serialized form to use fully-qualified names

Terasology / Tasks

A module to add questing features

Apache License 2.0

1 stars 12 forks source link

test: expect the serialized form to use fully-qualified names #24

Closed keturn closed 3 years ago

keturn commented 3 years ago

because https://github.com/MovingBlocks/Terasology/pull/4148

keturn commented 3 years ago

I do think the type handler has enough code in it to be worth testing.

Clearly there are some disadvantages to having the tests depend on the byte-for-byte result of the serialized form.

Not sure what the better way would be. It could compare PersistedData structures instead of the JSON string, but that might have the same problem if the expected PersistedData hard-codes those class references.

skaldarnar commented 3 years ago

This fails because MTE is not binary compatible with https://github.com/MovingBlocks/Terasology/pull/4539 (I think). I've triggered a rebuild of MTE and hope this will help (the tests run fine when testing this locally).