search

Terracotta-OSS / offheap-store

A library that provides a set of map and cache implementations that store data outside of the normal Java heap
Apache License 2.0
90 stars 46 forks source link

Issue #21 Consume a factory of ExecutorService to run the disk store #22

Closed chrisdennis closed 9 years ago

ljacomet commented 9 years ago

This change looks like it has API impact, which means the version should move to 2.2.x

If agreed, that change should be part of the PR.

chrisdennis commented 9 years ago

I didn't think about this too closely... but the erased types haven't changed, and the generic type parameters have only been loosened. I think this should be backwards compatible. Is that good enough @ljacomet or would you rather us move to 2.2.0 anyway?

ljacomet commented 9 years ago

Indeed, just had a look at the PR and did not look at the type relations.

Sounds good to me as a minor update on 2.1.x then - merging