search

Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
316 stars 157 forks source link

[UI] Reset sidebar scroll position to top when interacting with filters #257

Closed rudokemper closed 4 years ago

rudokemper commented 5 years ago

When you scroll down in the sidebar, and interact with the filters to change the sidebar content, the sidebar stays put in the same vertical position, although the content has changed.

The sidebar should reset back to the top when a filter has been selected.

@mirandawang may have some code to share that can be modified to do the job :)

MxOliver commented 5 years ago

Can I look into this?

rudokemper commented 5 years ago

That would be great, Oliver! :)

MxOliver commented 5 years ago

Just a clarification, when you click the filter you'd like the sidebar to scroll so that story is at the top of the sidebar? Or should it reset back to the very top regardless of what story was clicked? Like if Miranda is at the top and I click the Kalimar story, should it scroll so Kalimar is up top, or should it scroll back to Miranda to reset to the top?

rudokemper commented 5 years ago

Good question! I would say the very top, always.

Rudo Kemper Manager, Mapping & Programs Support Amazon Conservation Team - US 4211 N. Fairfax Drive, Arlington, VA 22203 Ofc: (+1) 703-522-4684 rkemper@amazonteam.org| www.amazonteam.org -------- Original message -------- From: Oliver notifications@github.com Date: 8/10/19 11:53 AM (GMT-05:00) To: Terrastories/terrastories terrastories@noreply.github.com Cc: Rudo Kemper rkemper@amazonteam.org, Author author@noreply.github.com Subject: Re: [Terrastories/terrastories] [UI] Reset sidebar scroll position to top when interacting with filters (#257)

Just a clarification, when you click the filter you'd like the sidebar to scroll so that story is at the top of the sidebar? Or should it reset back to the very top regardless of what story was clicked? Like if Miranda is at the top and I click the Kalimar story, should it scroll so Kalimar is up top, or should it scroll back to Miranda to reset to the top?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Terrastories/terrastories/issues/257?email_source=notifications&email_token=AHRSBC45BNJ6H243CYIB6SLQD3QALA5CNFSM4H5IULG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AQBPI#issuecomment-520159421, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHRSBCZ3IWGYMR74PSPMJ3TQD3QALANCNFSM4H5IULGQ.

mirandawang commented 4 years ago

closed here https://github.com/Terrastories/terrastories/pull/336