Time for Javascript coverage too!

Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.

https://terrastories.app

MIT License

316 stars 157 forks source link

Time for Javascript coverage too! #311

Closed kalimar closed 4 years ago

kalimar commented 4 years ago

In the spirit of https://github.com/Terrastories/terrastories/issues/276 - let's add javascript tests too.

[ ] Setup jest testing framework - one ticket
[ ] setup istanbul test coverage tool - one ticket
[ ] Add Javascript tests - these will be individual tickets.

The goal with this is to get everything ready for running continuous deployment with Travis CI

gabsprates commented 4 years ago

@kalimar, can i take this tasks?

gabsprates commented 4 years ago

@kalimar, actually, I saw you already have Jest and Coverage config on package.json file. Jest uses Istanbul, so looks like you can check the 1st and 2nd items of it's issue.

kalimar commented 4 years ago

Oh dang @gabsprates thanks for noticing that. One of our earlier contributors must have done this. I'll add the tests in a couple of days then. Sorry for the confusion.

kalimar commented 4 years ago

I should have done a bit more homework here before creating this ticket. I'm moving these notes over to a milestone and clarifying the requirements. https://github.com/Terrastories/terrastories/milestone/7