search

Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
316 stars 157 forks source link

[Bug][React] When a map Marker popup expands in size to accommodate an image, the X to close the popup stays where it was #600

Closed rudokemper closed 3 years ago

rudokemper commented 3 years ago

Describe the bug In Terrastories, it is possible to add an image for a Place marker. This gets visualized in the marker popup, when a user clicks on a Place marker point on the map.

If there is an image for a place, the popup expands in size to accommodate the image. But the X to close the popup stays where it was, in the original popup dimensions.

To Reproduce Steps to reproduce the behavior:

  1. Add an image for a place.
  2. Go to the map and click on the place to open the popup.
  3. See how the popup first loads as though there was no image, it then expands to include the image, but the X will stay where it was before the expansion.

Expected behavior When the popup expands, the X to close the popup also adjusts to be in the top right of the popup.

Screenshots image

astojanowski commented 3 years ago

Hi! I have fixed this bug.

rudokemper commented 3 years ago

Thanks so much @astojanowski!

astojanowski commented 3 years ago

I'm glad to help :)