search

Terrastories / terrastories

Terrastories is a geostorytelling application for mapping, managing and sharing place-based stories.
https://terrastories.app
MIT License
316 stars 157 forks source link

[Rails] Fix logo not loading on Rails error pages #810

Closed rudokemper closed 1 year ago

rudokemper commented 1 year ago

The Terrastories logo is not working on Rails error pages (404, 422, 500). You can access the 500 error page by going to any path that isn't used by Terrastories e.g. en/testing.

The logo path needs to be fixed here: <img src="../app/assets/images/logocombo.svg" width="80%">

image

asheerrizvi commented 1 year ago

I can take this @rudokemper

rudokemper commented 1 year ago

Thanks @asheerrizvi! I assigned you.

asheerrizvi commented 1 year ago

@rudokemper I am not able to get to the error page on local. When I try an invalid path I see this:

image
rudokemper commented 1 year ago

Ah, yeah I think the screen is shown when deployed in a production environment. You might need to either set that up, or figure out a way to get it to work in dev. Also, once you have made some commit, I can deploy to our staging server to make sure it all works 👍

asheerrizvi commented 1 year ago

hey @rudokemper have attempted a fix here: #858. Noticed a similar issue in 422 and 500 pages and have modified the path in those files as well.