search

TerriaJS / RaPPMap

Fork of TerriaJS/TerriaMap for GEOGLAM RAPP
5 stars 4 forks source link

Test and fix search #129

Open AnaBelgun opened 2 years ago

AnaBelgun commented 2 years ago

ran "land" and couldn't get duplicates image to test 'decline' - couldn't get any results

AnaBelgun commented 1 year ago

@mpaget Hi, would you please re-test this and let us know if still not working, We have updated the index and included an automated way to run it.

mcass-abares commented 1 year ago

Duplicate results still occur when using the Location search bar or searching the data catalogue using the location search bar. (24 November 2022). I'm not sure what the difference is with the location search returns. Data layer duplicates are because search returns are being drawn from both Australia and Global tab. DuplicateDatalayersearchreturns_20221124 DuplicateLocations_Parkes20221124

AnaBelgun commented 1 year ago

hi @nf-s I don't think there is an issue with search per se, right? Location results are drawn from a couple of geocoders and data search duplicates might be because of tabs.

meh9 commented 1 year ago

The search is correct - as far as the system is concerned these are two different layers. It is purely coincidental that they have the same name:

Screen Shot 2022-11-24 at 09 32 55 Screen Shot 2022-11-24 at 09 33 23
meh9 commented 1 year ago

There is an interesting bug here though, if you search the catalogue without having clicked on the different catalogue tabs you only get a partial path:

Screen Shot 2022-11-24 at 09 39 06

However, if you:

  1. Open the catalogue
  2. click on the Global tab
  3. click back to the Australia tab
  4. then search The path shown on hover shows the full path: Screen Shot 2022-11-24 at 09 38 41

We should fix that so the full path is always displayed.

nf-s commented 1 year ago

Different "Parkes" results are coming from the geocoder API.

image

@meh9 is correct in that both those layers are separate, so they will both appear in search results.

mcass-abares commented 1 year ago

Ok I see the hover over is available for data catalogue entries not locations. It would be great to have something like this for locations to be able to make an informed choice about which Geocoder return to choose e.g. the information you show above about the confidence of the return except I still can't see what the difference is between return 2-5.

Agree with your point above about not getting full paths when searching the whole catalogue without selecting "global" or "Australia" that would also be useful.