search

TerryHowe / ansible-modules-hashivault

Ansible module for Hashicorp Vault.
https://pypi.python.org/pypi/ansible-modules-hashivault
MIT License
454 stars 158 forks source link

ssh_role,token_role: don't fail when encountering unknown options #445

Closed bendem closed 1 year ago

bendem commented 1 year ago

Followup for 6cffb8d6deed7b01e1109b86395e6569b758d309. I can't figure out how to run the tests from my machine so here I am 😇

TerryHowe commented 1 year ago

Does https://github.com/TerryHowe/ansible-modules-hashivault#developer-note help? Testing is a bit odd, but that should work

bendem commented 1 year ago

Does https://github.com/TerryHowe/ansible-modules-hashivault#developer-note help? Testing is a bit odd, but that should work

I did get it working in the end, it was a weird combination of running in WSL (podman instead of docker), running behind corporate proxy, and a weird python setup.

bendem commented 1 year ago

I also had to add hvac to test-requirements.txt, otherwise it wasn't found when running tox. Not sure if it's related to my weird setup though.

bendem commented 1 year ago

I caught a mistake while fixing a change here, if there was an exception during normalization, it would be ignored. I'm now raising an exception and handling it to avoid those going under the radar.