search

TestArmada / nightwatch-extra

MIT License
30 stars 25 forks source link

nightwatch-extra does not support Nightwatch 1.x #121

Open rsheldiii opened 6 years ago

rsheldiii commented 6 years ago

When upgrading to nightwatch 1.0.0 or subsequent, the new api loader does not like the current way the testarmada assertions are written. I get this error:

The assertion module needs to contain an .assertion() method

which seems to come from here: https://github.com/nightwatchjs/nightwatch/blob/b3e1e1846ccabe806f54ab2bd8821b55e4e425ce/lib/api-loader/assertion.js#L43-L47

which suggests that instead of exporting the entire class, if the assertion files just exported the assertion function as module.exports.assertion, this would work with Nightwatch 1.x

pschroeder89 commented 5 years ago

In addition to the above issue with assertions, plugins (appium / dictionary) don't appear to load, either.

xenialaq commented 5 years ago

In addition to the above issue with assertions, plugins (appium / dictionary) don't appear to load, either.

In globals, plugins can no longer access this.test_settings which defines extra flags for Appium.