Th3Whit3Wolf / one-nvim

Atom one theme
MIT License
113 stars 23 forks source link

Add Neovim 0.5.x LSP highlights #3

Closed rnevius closed 3 years ago

rnevius commented 3 years ago

Not an issue as much as a feature request. Neovim 0.5.0 will include a built-in LSP client. This client defines some highlights, viewable at :help lsp-highlight. These may include the following for references:

LspReferenceText
LspReferenceRead
LspReferenceWrite

And the following for diagnostics, which are all in the form of LspDiagnostics<Something> with Error, Warning, Information and Hint variants:

LspDiagnosticsDefaultError
LspDiagnosticsDefaultWarning
LspDiagnosticsDefaultInformation
LspDiagnosticsDefaultHint
LspDiagnosticsVirtualTextError
LspDiagnosticsVirtualTextWarning
LspDiagnosticsVirtualTextInformation
LspDiagnosticsVirtualTextHint
LspDiagnosticsUnderlineError
LspDiagnosticsUnderlineWarning
LspDiagnosticsUnderlineInformation
LspDiagnosticsUnderlineHint
LspDiagnosticsFloatingError
LspDiagnosticsFloatingWarning
LspDiagnosticsFloatingInformation
LspDiagnosticsFloatingHint
LspDiagnosticsSignError
LspDiagnosticsSignWarning
LspDiagnosticsSignInformation
LspDiagnosticsSignHint

Thanks for the beautiful theme!

Th3Whit3Wolf commented 3 years ago

Thanks for the issue! I just updated the theme with all of these set.

onsails commented 3 years ago

@Th3Whit3Wolf thanks for the update! However theme still lacks LspReferenceText, LspReferenceRead and LspReferenceWrite which are crucial for working with rust sources.

I find the following highlights good enough for one-nvim dark:

  highlight LspReferenceText gui=reverse cterm=reverse
  highlight LspReferenceRead gui=reverse cterm=reverse
  " hue_6_2
  highlight LspReferenceWrite guibg=#e5c07b guifg=Black
Th3Whit3Wolf commented 3 years ago

Just updated. Let me know what you think.

onsails commented 3 years ago

Personally I prefer reference write to be more noticeable (bright bg):

image

Currently it's barely distinguisable from mut keyword and it's easy to miss state change:

image
Th3Whit3Wolf commented 3 years ago

Just updated, the reverse tricked me. Let me know what you think.

onsails commented 3 years ago

perfect, thanks!

Th3Whit3Wolf commented 3 years ago

No problem!