search

Th3Whit3Wolf / one-nvim

Atom one theme
MIT License
113 stars 23 forks source link

last commit has changed the normal background color #8

Closed yamatsum closed 3 years ago

yamatsum commented 3 years ago

https://github.com/Th3Whit3Wolf/one-nvim/commit/8767c8e2d5aa1d270252528b167f0eb0911bb77a This commit has changed the normal background color(syntax_bg). Is this an intended change?

This color is no longer one-dark https://github.com/atom/atom/tree/master/packages/one-dark-syntax https://github.com/joshdick/onedark.vim

yamatsum commented 3 years ago

https://github.com/Th3Whit3Wolf/one-nvim/commit/8767c8e2d5aa1d270252528b167f0eb0911bb77a#diff-c5275e2249049c055ced584c121ac0286dacfbfd26eb2c452b135f51937c745bR39-R41 I don't think it's good to add special color away from one-dark like this. Or "one" should not be used in the name.

Th3Whit3Wolf commented 3 years ago

Sorry about that, should be fixed now.