ThauEx / ffrk-proxy

Proxy for Final Fantasy Record Keeper written in node.js
GNU Lesser General Public License v3.0
39 stars 21 forks source link

Add Multi-Hit and Element-Hit to Hit-All #32

Closed KHShadowrunner closed 8 years ago

KHShadowrunner commented 8 years ago

Tweaked the Hit-All code to be a little more accurate in description, and added the ability to specify if the attack is either multi-hit (and how many hits it will do) or elemental (and which element the attack is)

KHShadowrunner commented 8 years ago

Something to note on this - the code works (I need to repull this as is and test it, but through the changing i've done with my personal stuff on this machine it works), but the value for arg2 is passed as a number, rather than a number in quotation like the json file uses (that is to say, the original json code is stored as "1" or "105", and after the code executes it is inserted as 1 or 105. The code still works however).

EDIT: Tested by adding this into the 8.0 RC - works fine.

KHShadowrunner commented 8 years ago

Ok, after all those changes - I've been able to confirm that with ID 7 we are able to do both multiple hits and elemental hits in addition to hit all. So! We may want to change the name from Hit-All to "Special Attack", and make Hit All optional, or we can just leave it as is - as long as we are adding the materia and attack - we can determine what element, how many targets in a single attack, and how many attacks it can do. This is ready for testing and uploading.

KHShadowrunner commented 8 years ago

This is broken - can't use [3], will need to come up with a strategy. This only crashes if a combat is not started with it running (since then the attribute doesn't exist)

KHShadowrunner commented 8 years ago

Should be fixed.

KHShadowrunner commented 8 years ago

Confirmed that this should work as-is.