ThauEx / ffrk-proxy

Proxy for Final Fantasy Record Keeper written in node.js
GNU Lesser General Public License v3.0
39 stars 21 forks source link

. #49

Closed Silent-Tom closed 8 years ago

Silent-Tom commented 8 years ago

-Resolved-

ThauEx commented 8 years ago

Afaik changing SB requires more than changing a number Have a look here: #20

ThauEx commented 8 years ago

I'm not sure, whether it is correct or not, maybe @SirPhoenix88 can help you. I think, he already worked with the soul break code.

KHShadowrunner commented 8 years ago

So this also occurs with swapping of record materia -if something that it was referencing was not there (If you only added the zealot materia, it would crash because it references a new attack attribute that no longer existed).

I noticed that you're doing a lot of replacing, which is fine. The question I would have is - have you tried to just add it on? Might make a difference - see the additional attack that gets added on for multi-hit (I think it's something like .attributes.join[], rather htan replace.

As you say, since it works if the person is already in the group - then the problem is likely that there is -something- in the code that is getting added that you're missing. I dont know what it is as I haven't delved into it, but likely there's some kind of attribute that's sneaked in - could be something like a debuff that gets added to the enemy, or a special value, that it's trying to reach but can't.

Busy today, but perhaps we can dig into it deeper later.

KHShadowrunner commented 8 years ago

hmmm can you submit the dumps of a time it fails and a time it succeeds? Your best bet for that is to run Fabul Castle (1 Stamina), fail and get the dunp, then cancel and switch up the party. Or, if I can get mine going I'll see if I can grab some sample data.

KHShadowrunner commented 8 years ago

yes, basically where you have made the changes and it does not allow you to battle because it crashes. The idea is that as long as all characters save one are the same, the only difference is what is different bteween the two files.

This would actually be even better if - given a unique SB that you havent' mastered yet, you fail by trying to add that SB to the character without the weapon (and it fails), then equip the weapon to see the differences.

I might be able to give that a go later today or tomorrow.

KHShadowrunner commented 8 years ago

Be sure to add this to Sir Phoneix's Issue as it ties into what he is trying to accomplish. We can look into expanding adding this as a feature - but the above knowledge will help us determine what we need to track for all of the characters and needs to be set or imported.