search

The-Balance-FFXIV / glam

A hugo theme for the balance
Other
5 stars 24 forks source link

Page Previews Loading 5.5 Data #309

Open MlleCanary opened 1 year ago

MlleCanary commented 1 year ago

image Image provided.

nonowazu commented 1 year ago

This is because the opengraph description is summarizing the body content:

king@xenogears:~$ wget -q -O - https://www.thebalanceffxiv.com/jobs/healers/scholar/best-in-slot/ | grep 'og:desc'
<meta property="og:description" content="SCH BiS and Gear Options 5.55 Savage Sets So, why the hell is SCH BiS 2.32 GCD this tier? The short answer is that our gear absolutely sucks for 2.41 this tier. We either have to take on a bunch of piety or use crafted gear, and neither one is efficient. 2.32 GCD lines up AF well, but sits on a sort of halfway point of DoT timings that requires us to alternate between 12 GCD and 13 GCD Bios, which can result in lost Bio ticks.">

If you look at the body of that page:

# SCH BiS and Gear Options

# 5.55 Savage Sets

***So, why the hell is SCH BiS 2.32 GCD this tier?***  \
The short answer is that our gear absolutely sucks for 2.41 this tier. We either have to take on a bunch of piety or use crafted gear, and neither one is efficient. 2.32 GCD lines up AF well, but sits on a sort of halfway point of DoT timings that requires us to alternate between 12 GCD and 13 GCD Bios, which can result in lost Bio ticks. This still makes it the most efficient GCD that we're able to hit at the moment damage wise, that doesn't throw off AF alignment or give us meme levels of mana efficiency.

Whereas the rendering for that template happens entirely out of the bis field in the front matter header. If you go to that link and click blame, you'll see that the content there was put in place 15 months ago — and the summary is drawing from that. The current editor config doesn't allow anyone to edit the body field, so that has remained untouched for the last ~15 months.

tl;dr - this isn't a bug in glam or the editor; remove the stuff in the body and it'll fix itself. For actual opengraph embeds, #308 has seo embeds which should fix that.

nonowazu commented 1 year ago

I think this issue can be closed. I spot-checked a few best-in-slot.md files and didn't see a body anymore.