The-Fireplace-Minecraft-Mods / Grand-Exchange

A new take on Minecraft Multiplayer Marketplaces
GNU General Public License v2.0
3 stars 3 forks source link

Incorrect strings on sell offer notifications involving items with NBT Tags #29

Closed Tophattingson closed 4 years ago

Tophattingson commented 4 years ago

Describe the bug Sell an item with an NBT tag, and you will get a message where the price and NBT tag are incorrectly swapped. For instance:

"Grand Exchange: Finished selling 6 x minecraft:gold_ingot:0 with NBT 99 at {RepairCost:0,display:{Name:"Butter Ingot"}} each"

It's also possible that the absence of information about how much an item was sold for when you sell items without NBT tags is a bug, rather than intentional. Example:

"Grand Exchange: Sold 10/20 x minecraft:cooked_porkchop:0."

To Reproduce

  1. Rename an item.
  2. List the renamed item for sale.
  3. Wait until it sells.

Versions (please complete the following information, do NOT say "latest"):