The-Modular-Mind / oscelot

OSC Mapping module for VCV Rack
GNU General Public License v3.0
20 stars 1 forks source link

Send /module/new when meow module changed #11

Open rjsmith opened 1 year ago

rjsmith commented 1 year ago

Fixes #9

Summary of changes:

rjsmith commented 1 year ago

Hi @The-Modular-Mind - I would appreciate your feedback on this first draft merge request. Testing it with my TouchOSC template now.

The-Modular-Mind commented 11 months ago

Hey RJ, sorry I didn't get back to this, I did makes some changes per your requests, I'll clean that up and post a test build today, let's follow up on this after.

The-Modular-Mind commented 11 months ago

Hey can you try the build from here and lmk: https://github.com/The-Modular-Mind/oscelot/releases/tag/latest

You'll see messages like this:

{ address: '/oscelot/moduleMeowMory/start', args: [ 'VCF', 'VCV VCF', 'Voltage-controlled filter', 7 ] }
...
...
{ address: '/oscelot/moduleMeowMory/end', args: 7 }
{ address: '/oscelot/bankMeowMory/start', args: 7 }
...
...
{ address: '/oscelot/bankMeowMory/end', args: 7 }
rjsmith commented 11 months ago

Will do - thanks! Might take a couple of days - will need to change my TouchOSC template code slightly from my own version of the PR.

I have also just added another PR (on top of my first PR) that implements my idea of saving client state in the OSC patch config / preset. Seems to work well locally https://github.com/The-Modular-Mind/oscelot/pull/12/commits/4142724b4ea5ec925d6626eef27ae95308bcb85a

On Sun, 16 Jul 2023 at 23:00, The-Modular-Mind @.***> wrote:

Hey can you try the build from here and lmk: https://github.com/The-Modular-Mind/oscelot/releases/tag/latest

You'll see messages like this:

{ address: '/oscelot/moduleMeowMory/start', args: [ 'VCF', 'VCV VCF', 'Voltage-controlled filter', 7 ] } ... ... { address: '/oscelot/moduleMeowMory/end', args: 7 }

{ address: '/oscelot/bankMeowMory/start', args: 7 } ... ... { address: '/oscelot/bankMeowMory/end', args: 7 }

— Reply to this email directly, view it on GitHub https://github.com/The-Modular-Mind/oscelot/pull/11#issuecomment-1637199229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFFV7JDTMYQDH6BIGT5Y7LXQRQANANCNFSM6AAAAAA2C5TF2Y . You are receiving this because you authored the thread.Message ID: @.***>

rjsmith commented 11 months ago

Hi - your test build works well, thanks very much.

rjsmith commented 11 months ago

HI - I have done some more testing, and realised that your proposed message is missing the same module name that is sent on the /fader/info message. My TouchOSC script needs that same string to match the info messages to the module:

RECEIVE    | ENDPOINT([::ffff:127.0.0.1]:49240) ADDRESS(/oscelot/moduleMeowMory/start) STRING(Bogaudio-AddrSeq) STRING(Bogaudio ADDR-SEQ) STRING(Voltage-addressable 8-step sequencer) INT32(10)
RECEIVE    | ENDPOINT([::ffff:127.0.0.1]:49240) ADDRESS(/fader) INT32(1) FLOAT(0)
RECEIVE    | ENDPOINT([::ffff:127.0.0.1]:49240) ADDRESS(/fader/info) INT32(1) STRING(ADDR-SEQ) FLOAT(0.5) STRING(Step 1) STRING(-10) STRING( V)

In the example above, the /start message needs the "ADDR-SEQ" string as an additional argument, or change the 2nd argument to just "ADDR_SEQ". Or maybe even change the /fader/info 2nd argument to match the 2nd argument of the /start message.

The-Modular-Mind commented 11 months ago

Will fix this in the next build