search

The-New-Platinum-Team / PlatinumQuest-Dev

The main repository for the game PlatinumQuest after the formation of new development team.
MIT License
14 stars 8 forks source link

ChangeEnvironmentTrigger #107

Closed AGame-1 closed 1 year ago

AGame-1 commented 1 year ago

Added the "Change Environment Trigger", which changes sun values/skybox upon entry. finally this exists

AGame-1 commented 1 year ago

Seems like I have push access now. Cool

RandomityGuy commented 1 year ago

I do not recommend using GuiInspector, that is not the correct way even though it is "Hacky". Do not create new "Sun" or "Sky". That kind of code should stay in mis mods, not here in the code base. Call %object.inspectPostApply(); After changing the fields of the Sun/Sky. Also don't use global variables to store "noted values", thats jank. Store them in the same object if you must (i.e, store them as fields for the sun or sky). The schedule method uses are unnecessary. More fun issues with this: Shaders: Marble and ice reflections, interior lighting. Changing environment stuff is not a good idea unless you know exactly just how much it affects the game. Also, it will definitely crash dedicated servers.

I'm sorry if I'm being harsh but code quality is to be enforced.