The-Nexus-Project / Limitless-6

Limitless 6 modpack maintained and developed by Gbergz.
10 stars 1 forks source link

Follow up for Starlight #50

Closed DraTrav closed 1 year ago

DraTrav commented 1 year ago
Screenshot 2023-02-18 172651

I'm just following up, I noticed crashes and weird performance issues on the client with starlight, However on the server side of things there are some major improvements to tps and mspt. My mspt before was 1500 and after was 300. I can get screenshots from spark if requested

I would recommend it for server side only.

Gbergz commented 1 year ago

So, no crashes because of Starlight on the server? Did you keep Canary, or did you remove it in favor of starlight? Maybe they're compatible.

DraTrav commented 1 year ago

They are compatible, I kept Canary and still saw massive improvement.

Gbergz commented 1 year ago

Did you add Starlight to an existing world? I am unsure whether this will cause unintended side effects if added to an existing. But I could be wrong.

Gbergz commented 1 year ago

I do want to test this on our official servers before adding it to the official server file pack. But not sure if it'll break it or not. 🤔

DraTrav commented 1 year ago

I did add it to an existing world, no negative side affects that I am aware of. It just affects the lighting engine. The worst it can do is cause bugs related to that, but I have not expericed any.

Gbergz commented 1 year ago

Alright, thank you for testing! I saw you said it was a huge improvement. To what parts exactly?

DraTrav commented 1 year ago

Overall tps and mspt, I did also notice already loaded chunks loading quicker and anything that gives off light having less of an effect on tps. For example, in my world I use glass domes a lot in building and because of how minecraft handles lighting it can actually cause some interesting "skips" whenever I teleport back. Starlight completely removed those skips. Its was also noticable with large amount of ice generating due to roller skates and frost walker. But starlight helped with the effect it had tremendously.

Gbergz commented 1 year ago

Interesting and good news then, I shall try it on the official servers soon, see what effect it gives.

DraTrav commented 1 year ago

Both of these were tested after about 10 mins of my server starting. Both were taken at the same location moving around the world.

This is before starlight

image

https://spark.lucko.me/4Few2t3JnY

This is after

image

https://spark.lucko.me/3o3L0E6RQp

Gbergz commented 1 year ago

Currently been testing on the Official Servers for about 5 hours, so far so good. 👍

Gbergz commented 1 year ago

Closing as I added this awhile back for Server Files only.