search

The-OpenROAD-Project / OpenROAD

OpenROAD's unified application implementing an RTL-to-GDS Flow. Documentation at https://openroad.readthedocs.io/en/latest/
https://theopenroadproject.org/
BSD 3-Clause "New" or "Revised" License
1.52k stars 530 forks source link

finish opendb logger conversion #907

Open maliberty opened 3 years ago

maliberty commented 3 years ago

There are still a fair number of calls to notice and other functions in dbLogger.h. Please finish the conversion to the new logger.

dralabeing commented 3 years ago

@maliberty Is this conversion to logger complete?

maliberty commented 3 years ago

No - @ahmadelrouby has been out but is return now.

titan73 commented 3 weeks ago

What exactly this conversion consists in? Btw, is it still valid?

maliberty commented 3 weeks ago

The conversion is from issuing messages with printf and the like to using the logger. I believe there are still areas that need doing.

titan73 commented 3 weeks ago

So whenever I get a message without a prefix like "[INFO ODB-0227]" that means it's not converted yet, right?

maliberty commented 3 weeks ago

Yes

rovinski commented 3 weeks ago

It means it could also be using logger->report() though

maliberty commented 3 weeks ago

It means it could also be using logger->report() though

That should be limited to true reports but there have been some abuses that should also be fixed. At least it is better than printf as it goes through the logger.