Open xneanq opened 1 month ago
Pocketflow is a radically simple and functional programming framework.
I agree that small size is a great marketing spin, but should not be it's core objective.
Agreed. The first thing I noticed when I looked at the code was the lack of type hints and the violation of standard PEP 8 formatting guidelines, such as a space between arguments in a function definition (def foo(a,b,c)
instead of def(a, b, c)
).
These things immediately give me a bad impression and make me disinclined to try out a project.
@bpshaver Don't be discouraged by its appearance, I asked Claude to reformat the library per PEP 8, and kept a copy of this in my local repo
@wgong the idea that you would use an LLM to do formatting when Black and Ruff exist for that purpose is strange to me. It tickles me to imagine someone who has integrated LLMs into their development workflow but not linters, formatters, and static type checkers. (FWIW, I’m not accusing you of that — you may just not work in Python.)
with all due respect i don't mean to be a curmudgeon. the repo docs created by your example look great and your lib is obviously effective: nice and simple cutting through the embellishment of the AI agent business (i might add your lib has nothing to do with AI) but the whole less than 100 lines thing is a bit contrived!
running it through ruff format makes it over 200 lines
I'm not trying to poo poo your efforts on account of line numbers but I'm just wondering if you would be open to making that not an objective? you've obviously taken liberties with readability to achieve this, and we all love an obfuscated code contest but why not go the whole hog and make it type safe with verbose variable names etc?