search

TheAMM / mpv_thumbnail_script

A Lua script to show preview thumbnails in mpv's OSC seekbar, sans external dependencies
GNU General Public License v3.0
679 stars 68 forks source link

no close button #65

Open github-account1111 opened 4 years ago

github-account1111 commented 4 years ago

Normally, a title bar with window controls (close, minimize, maximize) appears when I hover over the top of the video. When using the script and turning off the built-in OSC, the title bar no longer appears upon hover. The bottom bar is still there.

hooke007 commented 4 years ago

no-border? That's right. This script is modified from the much old version of the osc.lua. So you won't see the top tiltle bar in the borderless mode.

github-account1111 commented 4 years ago

no-border?

Yup.

That's a bummer. So it's either seek preview or being able to exit / minimize with a mouse?

Hrxn commented 4 years ago

Uh, what? no-osc (or alternative OSC (i.e. mpv_thumbnail_script)) and no-border should be independent from each other?

github-account1111 commented 4 years ago

@Hrxn I'm not sure if you're responding to me or the other person. What are you saying?

hooke007 commented 4 years ago

no-border?

Yup.

That's a bummer. So it's either seek preview or being able to exit / minimize with a mouse?

I have a solution if you don't mind the different style of the layout. You can get it from: https://github.com/hooke007/mpv_thumbnail_script/releases https://github.com/hooke007/MPV_lazy_osc

github-account1111 commented 4 years ago

no-border?

Yup. That's a bummer. So it's either seek preview or being able to exit / minimize with a mouse?

I have a solution if you don't mind the different style of the layout. You can get it from: https://github.com/hooke007/mpv_thumbnail_script/releases https://github.com/hooke007/MPV_lazy_osc

Oh hey that works! Thank you so much! Would you by any chance also have a solution for #67?

github-account1111 commented 4 years ago

Actually, I might've found a bug. I can't seem to be able to navigate the video with the modded seekbar.

hooke007 commented 4 years ago

Oh hey that works! Thank you so much! Would you by any chance also have a solution for #67?

Try to modify vidscale=false in osc_mod.lua

Actually, I might've found a bug. I can't seem to be able to navigate the video with the modded seekbar.

I don't know your situation. Maybe you can test that script on the pure edition.

github-account1111 commented 4 years ago

Try to modify vidscale=false in osc_mod.lua

Yeah I've tried that. Didn't help. Tried no and tried false.

I don't know your situation. Maybe you can test that script on the pure edition.

So you can navigate videos on your end? If so, just to make sure, mpv_thumbnail_script_client_osc.lua stays the same, right (no need to remove)?

hooke007 commented 4 years ago

So you can navigate videos on your end? If so, just to make sure, mpv_thumbnail_script_client_osc.lua stays the same, right (no need to remove)?

I guess you ignore the description in my page (It is not compatible with other osc-like files.) So any files which were related to the old version of thumbnail_script should be cleaned up.

Yeah I've tried that. Didn't help. Tried no and tried false.

After you tried false, the box should always be the same size. But it will be forced to be downscaled when the window size is too small.

github-account1111 commented 4 years ago

I guess you ignore the description in my page

I didn't ignore anything. I did not realize that that's what you meant. I thought you were talking about some unrelated scripts.

In any case, that didn't seem to have changed much. But what I've noticed is that navigation does work if I launch the video for the second time.

After you tried false, the box should always be the same size. But it will be forced to be downscaled when the window size is too small.

Not the case on my end. It's smaller even on medium-sized videos.

Even if it did behave the way you're describing it wouldn't be very usable, since it's too small to click on anything. Why not leave the vertical size the same instead of shrinking the whole thing? That way it would at least be clickable.

hooke007 commented 4 years ago

Why not leave the vertical size the same instead of shrinking the whole thing? That way it would at least be clickable.

Eh....the vertical size....it is related with the other size of the elements. If you want it to be a fixed size, the only way is to totally rewrite the part codes of the osc UI.

Even if it did behave the way you're describing it wouldn't be very usable, since it's too small to click on anything.

Then you can modify the scalewindowed=<number> to make the box larger or smaller. However I don't think it will truly solve your problem.(I've said the reason before.)