Overwatch stats showing `undefined`

[Midni8]

Prerequisites

• [x] Checked the FAQs on the website for common solutions: https://bastionbot.org/faq
• [x] Checked that your issue isn't already filed: https://github.com/TheBastionBot/Bastion/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen
• [x] Checked that there is not already an open pull request that provides the described functionality: https://github.com/TheBastionBot/Bastion/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20
• [ ] Reproduced the problem with the code in the (latest) dev branch

Description

When the overwatch command is used for any player who does not have any stats, the stats are shown as undefined. This is a recent issue, it was not happening in older versions of Bastion.

Steps to Reproduce

1. Use the overwatch command for a new user or for someone who does not have any stats.
2. See the output

Expected behavior:
Showing N/A or Not Available or something easily understandable is a better choice.

Actual behavior:
The output shows undefined.

Reproduces how often:
Everytime

Additional Information

No additional information.

Versions

• Bastion version: 5.2
• Operating System (including version): Ubuntu 16.04 64-bit
• Node.js version: 9.0.0
• npm version: 5.5.1

[iamtraction]

I saw that for a case in the #commands-testing channel. I will fix it in the next release.

[iamtraction]

The issue is not actually for new players or players with no stats, but with the library that Bastion uses to get Overwatch stats and the way it gets them (by scrapping the Overwatch website). That's not a good way to retrieve data, and since there are no other options, that's the only way too. So, when Overwatch made some changes to the site, the data retrieved from the library changed and caused every (most) keys to be undefined. But I've updated the code and fixed the issue. The fix will be released with the next release.

Thanks for reporting the issue! :ok_hand:

[Midni8]

Oh I see. Thank you for the fix. :1st_place_medal: