search

TheCocoaProject / cordova-plugin-nativestorage

Cordova plugin: Native storage of variables in Android, iOS and Windows
http://thecocoaproject.github.io/
Apache License 2.0
292 stars 106 forks source link

add support for windows10 platform #38

Closed 3h3c closed 8 years ago

GillesC commented 8 years ago

Could you proivide me some info, about what you've just done? Because I'm not a Windows 10 dev. For instance, I see a vault var, does this mean the stored value is encrypted in any way?

3h3c commented 8 years ago

hey,

The PasswordVault lets application to store and retrieve user’s credentials in a secure way: all password are encrypted and cannot be accessed by other applications.

see: https://msdn.microsoft.com/de-de/library/windows/apps/windows.security.credentials.passwordvault.aspx

GillesC commented 8 years ago

I'll test your PR, if everything is OK. I'll merge it.

alokrajiv commented 8 years ago

Is the test suite passing?

GillesC commented 8 years ago

I'm installing the requirements for testing on Windows 10 :) I'll check the other platforms now.

GillesC commented 8 years ago

Android & browser passed the test.

3h3c commented 8 years ago

hey,

any new news?

GillesC commented 8 years ago

I've installed VS 2015. But I'm unable to run our test suite. The following error occured: "Error: Properties.PublisherDisplayName elements must be non-empty in appxmanifest at undefined"

Extra info: command was "cordova run windows", and I had an available windows device "Available windows devices: 0. Device (device)".

3h3c commented 8 years ago

try to build it with:

cordova build windows --arch="x86" and run with cordova run windows --arch="x86"

GillesC commented 8 years ago

I got the same result: image

3h3c commented 8 years ago

you have to change your config.xml.

add these lines:

<author email="example@example.com" href="http://example.com/">Example Company</author>

GillesC commented 8 years ago

Windows: not passed

Things to do:

Please see this section to test your implementation. Change the git clone to your repo.

GillesC commented 8 years ago

Errors thrown because of 'Encryption' tests, can be disgarded because it isn't implemented in iOS. And Windows functionality has priority. So the only errors you can have are these related to the encryption methods.

GillesC commented 8 years ago

Commit not confirmed. The returned value is now undefinied. (Error: Expected undefined to equal 154243)

Debug output from VS:

'WWAHost.exe' (Script): Loaded 'Script Code (MSAppHost/2.0)'. 
Exception was thrown at line 37, column 5 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-test-framework/www/medic.js
0x800c0005 - JavaScript runtime error: The system cannot locate the resource specified.
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Expected undefined to equal 154243.
Exception was thrown at line 15, column 13 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-nativestorage/src/windows/NativeStorage.js
0x80070490 - JavaScript runtime error: Element not found.

Cannot get credential from Vault
WinRT information: Cannot get credential from Vault
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Expected 'failed to get Item from NativeStorage - Element not found.

Cannot get credential from Vault' to equal 2.
Exception was thrown at line 276, column 9 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-nativestorage/www/mainHandle.js
0x800a13aa - JavaScript runtime error: Circular reference in value argument not supported
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Failed: Set item Failed
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Failed: Set item Failed
Exception was thrown at line 35, column 13 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-nativestorage/src/windows/NativeStorage.js
0x800a1391 - JavaScript runtime error: 'packageId' is undefined
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Failed: Error when clearing native storage
The program '[12076] WWAHost.exe' has exited with code 1 (0x1).
alokrajiv commented 8 years ago

Are the tests passing? You merged it?

GillesC commented 8 years ago

Tests have passed, and it's merged! :)

GillesC commented 8 years ago

Gonna publish it to NPM now.

GillesC commented 8 years ago

Published on NPM