TheCodeMonks / Notzz-App

📝 A Simple Note-Taking App built to demonstrate the use of Modern Android development tools - (Kotlin, Coroutines, State Flow, Hilt-Dependency Injection, Jetpack DataStore, Architecture Components, MVVM, Room, Material Design Components).

MIT License

667 stars 53 forks source link

please increase versionCode #47

Closed IzzySoft closed 3 years ago

IzzySoft commented 3 years ago

could you please increase versionCode when making a new release? That's what Android tells the versions apart by – so as today's release still has versionCode: 1 Android won't consider it as an update for those having the previous version installed. Thanks!

Spikeysanju commented 3 years ago

@IzzySoft Sure man! Thanks for the info

IzzySoft commented 3 years ago

Gladly given! Now your 3rd release was made, and versionCode is still set to 1. Maybe leave the issue open so you don't forget? :rofl:

Spikeysanju commented 3 years ago

Haha Sorry my bad 🤣 . Every time I forgot to update the version code. Thanks for the reminder 👍

Spikeysanju commented 3 years ago

@IzzySoft It was fixed in the latest commit buddy ✅ . Thanks for the reminder. Have a great day!

IzzySoft commented 3 years ago

:rofl: Please reopen again, you once more forgot versionCode – it's still set to 1 but should be, err, 4 meanwhile?

    defaultConfig {
        applicationId "thecodemonks.org.nottzapp"
        minSdkVersion 21
        targetSdkVersion 30
        versionCode 1
        versionName "1.3.3"

Remember:

versionName: what's displayed to the user (and most likely will be used when reporting issues)
versionCode: what Android uses internally to tell versions apart; this is the most important one to always increase with each new release

IzzySoft commented 3 years ago

@Spikeysanju my updater still gives me daily alerts because of the versionCode, so I'm disabling the update check for now. Please drop me a note once you fixed it, @Spikeysanju – thanks!

IzzySoft commented 3 years ago

@Spikeysanju any chance? Btw it's irritating that the APK at release tag v1.3 still identifies as 0.1.3 :wink:

IzzySoft commented 2 years ago

@Spikeysanju again you forgot: my updater just fetched a new version last night (we're at 1.4 now), and it still shows versionCode: 1. None of your users will ever receive update notifications, or be otherwise aware of new versions: even if they look at their F-Droid app, it will seem to them that they have the latest version already installed – as Android thinks so.

Maybe one year after reporting, can we get this finally fixed, please? Thanks!

Spikeysanju commented 2 years ago

@IzzySoft Oops I'm sorry I forgot to update the version everytime 😬.

I've updated the version code to 4. Please check it out. Thanks for bringing this up 🙌

Checkout the latest 👇 release

Checkout latest pr 👇

241

IzzySoft commented 2 years ago

Thanks! That one looks good. Just downloaded it manually (as my updater was now fooled by the fact it already had processed that tag) and checked. Will become visible in about 1.5h from now (with the next sync).

Will it now work well for the next releases, too? :smiley:

Spikeysanju commented 2 years ago

Yeah sure, I hope I will remember this for sure next time 😄. Have a great day buddy!

IzzySoft commented 2 years ago

You too, friend! And should you forget again, I'll come and remind you :laughing: