fix(Tooltip.svelte): don't destroy tip node, let svelte do it

TheComputerM / svelte-materialify

A Material UI Design Component library for Svelte heavily inspired by vuetify.

https://svelte-materialify.vercel.app

MIT License

622 stars 83 forks source link

fix(Tooltip.svelte): don't destroy tip node, let svelte do it #268

Open dablach opened 2 years ago

dablach commented 2 years ago

When destroying a Tooltip, the tooltip node was removed twice: once by svelte and once by the component.

This pull requests removes the removeChild call in the component and adds a test, that checks if the Tooltip component can be destroyed without an error and the tooltip node gets removed correctly.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/9ZrQCqm2zkK8cqrCRFyZaDxaRASh
✅ Preview: https://svelte-materialify-git-fork-dablach-master-thecomputerm.vercel.app