search

TheDan64 / inkwell

It's a New Kind of Wrapper for Exposing LLVM (Safely)
https://thedan64.github.io/inkwell/
Apache License 2.0
2.38k stars 229 forks source link

Expose `pub(crate) fn new` constructors for value types #457

Closed corbanvilla closed 9 months ago

corbanvilla commented 11 months ago

Description

Exposing these constructors is helpful when working with LLVM code which isn't yet part of the C-API.

Related Issue

Checklist

TheDan64 commented 10 months ago

@corbanvilla The newly pub fns need doc comments. Also, Value::new should not be pub since it is internal. Once those are fixed we can merged this

corbanvilla commented 9 months ago

@TheDan64 apologies for the delay, just added doc comments!

TheDan64 commented 9 months ago

@corbanvilla there appear to be some merge conflicts that need to be resolved

corbanvilla commented 9 months ago

@TheDan64 Could you clarify where you're referring to.... it looks up to date under the files changed tab.

TheDan64 commented 9 months ago

For some reason I see image

TheDan64 commented 9 months ago

ah okay it looks like I can do a regular merge instead of a rebase...