search

TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
31 stars 6 forks source link

Attempt to come up with a more scalable approach to logging. #1000

Closed AdvancedImagingUTSW closed 1 month ago

AdvancedImagingUTSW commented 1 month ago

Let me know what you think...

The only thing I don't like is that the logging reports the location of the decorator, not the class itself...

2024-09-26 11:00:04,258 - controller - INFO - decorators: 'StageController' Initialized

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 64.28571% with 85 lines in your changes missing coverage. Please review.

Project coverage is 53.65%. Comparing base (9120c03) to head (e0e0416). Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/features/common_features.py 22.22% 14 Missing :warning:
src/navigate/model/model.py 36.84% 12 Missing :warning:
src/navigate/plugins/plugin_manager.py 28.57% 10 Missing :warning:
src/navigate/model/devices/APIs/sutter/MP285.py 0.00% 6 Missing :warning:
src/navigate/model/devices/camera/hamamatsu.py 0.00% 6 Missing :warning:
src/navigate/model/devices/camera/photometrics.py 0.00% 3 Missing :warning:
src/navigate/model/features/image_writer.py 72.72% 3 Missing :warning:
...ate/model/devices/APIs/asi/asi_tiger_controller.py 0.00% 2 Missing :warning:
src/navigate/model/devices/daq/ni.py 0.00% 2 Missing :warning:
src/navigate/model/devices/filter_wheel/ni.py 0.00% 2 Missing :warning:
... and 17 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1000 +/- ## =========================================== + Coverage 53.54% 53.65% +0.11% =========================================== Files 178 178 Lines 19959 20032 +73 =========================================== + Hits 10687 10749 +62 - Misses 9272 9283 +11 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1000/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1000/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `53.65% <64.28%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.