TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
32 stars 7 forks source link

1008 laser digital only modulation doesnt work #1011

Closed AdvancedImagingUTSW closed 1 month ago

AdvancedImagingUTSW commented 1 month ago

Ended up being more of an exploration on type hinting to make debugging in an IDE easier. Will circle back to #1008

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 74.44934% with 58 lines in your changes missing coverage. Please review.

Project coverage is 53.87%. Comparing base (2f416f4) to head (6589ca7).

Files with missing lines Patch % Lines
src/navigate/model/devices/daq/ni.py 0.00% 16 Missing :warning:
src/navigate/model/device_startup_functions.py 70.83% 14 Missing :warning:
src/navigate/model/devices/camera/hamamatsu.py 0.00% 6 Missing :warning:
src/navigate/model/devices/stages/asi.py 25.00% 6 Missing :warning:
...navigate/model/devices/stages/asi_MSTwoThousand.py 0.00% 5 Missing :warning:
src/navigate/model/model.py 50.00% 4 Missing :warning:
.../model/devices/remote_focus/equipment_solutions.py 0.00% 3 Missing :warning:
src/navigate/model/devices/camera/photometrics.py 0.00% 2 Missing :warning:
src/navigate/model/devices/remote_focus/ni.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1011 +/- ## =========================================== + Coverage 53.77% 53.87% +0.09% =========================================== Files 178 178 Lines 20080 20168 +88 =========================================== + Hits 10799 10866 +67 - Misses 9281 9302 +21 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1011/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1011/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `53.87% <74.44%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AdvancedImagingUTSW commented 1 month ago

Thanks @JinlongL for testing the PR

JinlongL commented 1 month ago

[like] Jinlong Lin reacted to your message:


From: Kevin M. Dean @.> Sent: Tuesday, October 8, 2024 9:43:45 PM To: TheDeanLab/navigate @.> Cc: Jinlong Lin @.>; Mention @.> Subject: Re: [TheDeanLab/navigate] 1008 laser digital only modulation doesnt work (PR #1011)

EXTERNAL MAIL

Thanks @JinlongLhttps://urldefense.com/v3/__https://github.com/JinlongL__;!!MznTZTSvDXGV0Co!EWlhLNoh7sDgFEaG3OMKT7BFKDl9JkHlJDDHD5dj2nHIVMJ34KkdMVidnDaNqkSXdqgcxMZIGksb2sIQhuUdflMF52qfIeD9dzg$ for testing the PR

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/TheDeanLab/navigate/pull/1011*issuecomment-2400875224__;Iw!!MznTZTSvDXGV0Co!EWlhLNoh7sDgFEaG3OMKT7BFKDl9JkHlJDDHD5dj2nHIVMJ34KkdMVidnDaNqkSXdqgcxMZIGksb2sIQhuUdflMF52qf8FLnGwc$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AW5R4SG2E5B2G64BJN7TMTLZ2RGZDAVCNFSM6AAAAABPSG6WZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQHA3TKMRSGQ__;!!MznTZTSvDXGV0Co!EWlhLNoh7sDgFEaG3OMKT7BFKDl9JkHlJDDHD5dj2nHIVMJ34KkdMVidnDaNqkSXdqgcxMZIGksb2sIQhuUdflMF52qfqHC80O0$. You are receiving this because you were mentioned.Message ID: @.***> CAUTION: This email originated from outside UTSW. Please be cautious of links or attachments, and validate the sender's email address before replying.


UT Southwestern

Medical Center

The future of medicine, today.