search

TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
31 stars 6 forks source link

Type hinting the model... #1016

Closed AdvancedImagingUTSW closed 17 hours ago

AdvancedImagingUTSW commented 2 weeks ago

And some related methods and classes that it calls. Slowly eliminating perceived problems by Pycharm...

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 91.07143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.30%. Comparing base (fd79b51) to head (8693802). Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/model.py 90.69% 4 Missing :warning:
src/navigate/model/features/common_features.py 33.33% 2 Missing :warning:
src/navigate/model/features/remove_empty_tiles.py 0.00% 2 Missing :warning:
src/navigate/model/data_sources/__init__.py 0.00% 1 Missing :warning:
src/navigate/model/features/adaptive_optics.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1016 +/- ## =========================================== + Coverage 54.26% 54.30% +0.03% =========================================== Files 180 180 Lines 20282 20302 +20 =========================================== + Hits 11006 11024 +18 - Misses 9276 9278 +2 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1016/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `54.30% <91.07%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.