TheDeanLab / navigate

navigate - open source light-sheet microscope controls
https://thedeanlab.github.io/navigate/
Other
32 stars 7 forks source link

Update microscope.py #1026

Closed AdvancedImagingUTSW closed 3 weeks ago

AdvancedImagingUTSW commented 3 weeks ago

Added type annotations, and extracted a few methods to make some of the code a bit more readable.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.31%. Comparing base (365fbad) to head (422f5ea). Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/navigate/model/microscope.py 84.78% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1026 +/- ## =========================================== + Coverage 54.30% 54.31% +0.01% =========================================== Files 180 180 Lines 20302 20319 +17 =========================================== + Hits 11025 11037 +12 - Misses 9277 9282 +5 ``` | [Flag](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1026/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/TheDeanLab/navigate/pull/1026/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab) | `54.31% <84.78%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheDeanLab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.