Closed murdos closed 6 months ago
In our project we have a direct dependency to com.electronwill.night-config:toml and have not declared transitive dependency com.electronwill.night-config:core.
com.electronwill.night-config:toml
com.electronwill.night-config:core
This was working fine with version 3.6.7, but this breaks with release 3.7.0, probably because the dependency was declared with the implementation scope, instead of the compile scope: https://github.com/TheElectronWill/night-config/commit/a28de26d47a5cb779894ffbe6e46d0011f06ce83#diff-7ad97c2e202fcb1d5aaf7d96f47fefd0ecf6d9f7f11d51d68584abfa9fb0f63aR11
implementation
compile
You can compare generated pom.xml :
<dependency> <groupId>com.electronwill.night-config</groupId> <artifactId>core</artifactId> <version>3.6.7</version> <scope>compile</scope> </dependency>
<dependency> <groupId>com.electronwill.night-config</groupId> <artifactId>core</artifactId> <version>3.7.0</version> <scope>runtime</scope> </dependency>
You are right, it should be api instead of implementation (compile has been deprecated for some time already). I'll release v3.7.1 to fix that.
api
Thank you for opening an issue!
In our project we have a direct dependency to
com.electronwill.night-config:toml
and have not declared transitive dependencycom.electronwill.night-config:core
.This was working fine with version 3.6.7, but this breaks with release 3.7.0, probably because the dependency was declared with the
implementation
scope, instead of thecompile
scope: https://github.com/TheElectronWill/night-config/commit/a28de26d47a5cb779894ffbe6e46d0011f06ce83#diff-7ad97c2e202fcb1d5aaf7d96f47fefd0ecf6d9f7f11d51d68584abfa9fb0f63aR11You can compare generated pom.xml :